https://msi.dev.umn.edu/about-msi/our-experts

https://xd.adobe.com/view/6203a662-6367-493c-88c0-3090751c3d1e-3750/screen/6da30f46-0d24-44cb-95c9-4a5341211f14/

Not sure if you and Lau agreed on something else but the images should be the same size vs the two big chiefs being larger - task with details

James and Ben look larger -

Screenshot 2024-12-11 at 13.36.39.png 608 KB • Download

Thanks Robyn ,

I did not chat with Laura about making this change. However the design shows different sizes for the main guys:

image.png 922 KB • Download

The top images are larger and almost square. if I have to make them more square it will stretch the current images and distort it. So I kept the size ratio and just made them larger. The size differences on the design is: 296px and 220px for the smaller ones 

Please advise what you think is best here and I will do that

David I hear you - I know Ian flagged a concern about Expert images when we met with Lau a few weeks ago - The width of the top row is wider than the second row, however what we have on production is a width and height being larger - I am not usually the visual tester but think it needs adjustment - lets chat tomorrow morning and get some other opinions in standup - 

Thanks Robyn ,

I think that is a good idea. I am happy to do the changes. Let see what feedback we get

Robyn David  I remember we discussed this previously, and Laura was ok with this change. The issue we're trying to solve is badly cropping images; with square images we run the risk of a bad crop. 

Ian okay great, so what we have now is fine?

image.png 153 KB • Download

It probably still needs a good test. What does this look like with 3 people in the top section? 

I'm also noticing a forward slash on the other tabs, next to the first person's missing image. 

hmmm yes, that is weird, I will check what's happening in the back-end and add some more people to confirm that we can move on - thanks Ian  

David  think you will need to check out the forward slash, nothing obvious in the backend 

Okay Perfect will do

The "/" is the output of the image alt tag when it returns null. This is not a new change. It was probably never picked up because there was always an image showing. However I updated the code to say expert instead if it returns null 

image.png 9.38 KB • Download

Update here:

All the alt tags for all images were showing "/" even on live. I have updated it that they now work correctly.

I have removed my missing alt tag code. By default you cannot add an image without a alt text

I also added the justified content styling, however it required a lot of tweaking. As we want it to be justified left if there is 1 or 2 images. I have a fix and will push it up to DEV soon  

David I tried to remove the clone I created but it seems to be stuck in there now, even when using the cache buster,  it also was not called what I called it so I am not sure what's going on here - going to pick up the full test of this when I return in January 

Saw another task that answered this question David  - thank you!